Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support slack_channel as receiver #85

Closed
wants to merge 1 commit into from
Closed

feat: support slack_channel as receiver #85

wants to merge 1 commit into from

Conversation

manishdangi98
Copy link

No description provided.

@mabdh
Copy link
Member

mabdh commented Oct 10, 2024

@manishdangi98 the implemnentation seems not as expected. we should not create another router for this. the requirements is

  • The PostNotification API would handle the case:
    • if the receiver is the parent receiver, the channel name config is overridable from the API

@manishdangi98
Copy link
Author

manishdangi98 commented Oct 14, 2024 •
edited
Loading

Sure @mabdh, will update implementation for this.

@manishdangi98
Copy link
Author

Closing this MR
Separate MR is raised for support slack_channel passed in configs while calling PostNotifciationAPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabdh mabdh Awaiting requested review from mabdh mabdh will be requested when the pull request is marked ready for review mabdh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manishdangi98 @mabdh